Skip to content

Set cache headers on package collection requests #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

Set cache headers on package collection requests #3888

merged 1 commit into from
Oct 7, 2025

Conversation

daveverwer
Copy link
Member

Might fix: #3885

My guess as to why this has manifested now is that SwiftPM/Xcode in Swift 6.2 check for a content-length where in earlier versions they did not.

Unfortunately, the content-length response header is being removed by Cloudflare. For proof of this, check these two logs:

$ curl -svo /dev/null --http2 --compressed https://swiftpackageindex.com/daveverwer/collection.json 

…
…
…
 
* Request completely sent off
< HTTP/2 200 
< date: Mon, 06 Oct 2025 22:06:31 GMT
< content-type: application/json; charset=utf-8
< server: cloudflare
< vary: accept-encoding
< last-modified: Mon, 06 Oct 2025 22:06:31 GMT
< cache-control: no-store
< cf-cache-status: MISS
< content-encoding: gzip
< cf-ray: 98a87761b9d2b2e5-LHR
< 
{ [1360 bytes data]
* Connection #0 to host swiftpackageindex.com left intact

and direct to source, bypassing Cloudflare:

$ curl -svo /dev/null --http2 --compressed http://spi-prod.swiftpackageindex.com/daveverwer/collection.json 

…
…
…
 
* Request completely sent off
< HTTP/1.1 200 OK
< content-type: application/json; charset=utf-8
< content-length: 16245
< connection: keep-alive
< date: Mon, 06 Oct 2025 22:07:28 GMT
< 
{ [13830 bytes data]
* Connection #0 to host spi-prod.swiftpackageindex.com left intact

This patch sets an explicit cache control header that Cloudflare will interpret and honour to not modify anything coming from the server. Specifically, the no-transform header is what will hopefully stop it removing the header.

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2025
@daveverwer daveverwer mentioned this pull request Oct 6, 2025
Closed
@daveverwer daveverwer merged commit af47d66 into main Oct 7, 2025
5 of 6 checks passed
@daveverwer daveverwer deleted the cache-control branch October 7, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finestructure finestructure finestructure approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to add Package Collection in Xcode
2 participants
@daveverwer @finestructure